Fix possible discrepancy in circuit breaker in parent/child #5526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -144,6 +144,8 @@ public ParentChildAtomicFieldData loadDirect(AtomicReaderContext context) throws | |||
| } | |||
| if (success) { | |||
There was a problem hiding this comment.
should this happen in yet another try / finally or do you want to close the builders in a way that they can't throw an exception?
|
I left a comment @martijnvg |
…e loading if the loading wasn't successful.
|
@s1monw I added a commit. |
|
LGTM |
martijnvg
added a commit
that referenced
this pull request
Mar 25, 2014
…e loading if the loading wasn't successful. Closes #5526
martijnvg
added a commit
that referenced
this pull request
Mar 25, 2014
…e loading if the loading wasn't successful. Closes #5526
clintongormley
added
the
:Core/Infra/Circuit Breakers
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…e loading if the loading wasn't successful. Closes elastic#5526
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the actual bytes used in circuit breaker back to how it was before loading if the loading wasn't successful.