Properly quote $JAVA in bin/plugin #5765
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The all new Oracle Java 7 on OSX keeps $JAVA has JAVA_HOME=/Library/Internet Plug-Ins/JavaAppletPlugin.plugin/Contents/Home Note the happy space in "Internet Plug-Ins" - it gives plugin major agida...
|
Uh. Very valid PR. Can you sign the CLA, so I can get it in? See http://www.elasticsearch.org/contributor-agreement/ |
|
done |
spinscale
changed the title
spinscale
pushed a commit
that referenced
this pull request
Jul 18, 2014
The all new Oracle Java 7 on OSX has a space in its path resulting in bin/plugin failing to work Closes #5765
spinscale
pushed a commit
that referenced
this pull request
Jul 18, 2014
The all new Oracle Java 7 on OSX has a space in its path resulting in bin/plugin failing to work Closes #5765
clintongormley
changed the title
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
The all new Oracle Java 7 on OSX has a space in its path resulting in bin/plugin failing to work Closes elastic#5765
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The all new Oracle Java 7 on OSX has
JAVA_HOME=/Library/Internet Plug-Ins/JavaAppletPlugin.plugin/Contents/Home
Note the happy space in "Internet Plug-Ins" - it gives plugin
major agida...