Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing docs and tests for _cat/segments #5856

Closed
javanna opened this issue Apr 17, 2014 · 4 comments
Closed

Missing docs and tests for _cat/segments #5856

javanna opened this issue Apr 17, 2014 · 4 comments
Assignees
Labels
>docs General docs changes good first issue low hanging fruit help wanted adoptme v1.5.0 v2.0.0-beta1

Comments

@javanna
Copy link
Member

javanna commented Apr 17, 2014

We added _cat/segments api in #4711, but its docs are missing and we need to add some REST tests for it.

@javanna javanna changed the title Missing docs for _cat/segments Missing docs and tests for _cat/segments Apr 17, 2014
@clintongormley clintongormley added >docs General docs changes good first issue low hanging fruit help wanted adoptme labels Dec 30, 2014
@cbuescher cbuescher self-assigned this Jan 5, 2015
@cbuescher
Copy link
Member

Hi, writing the Rest-Tests, I realized the _cat/segments command raises an "IndexMissingException" on an empty cluster where other commands like 'shards', 'aliases' etc... return silently. Want me to change that as well or test for the 404 error?

@javanna
Copy link
Member Author

javanna commented Jan 7, 2015

Hey @cbuescher good point! I'd say keep it consistent with other cat apis, it makes sense not to return an exception if the cluster has no indices. Maybe send a separate PR for this change, so we can isolate it since we might need to mark it as breaking.

@cbuescher
Copy link
Member

Hi @javanna, do you think I should open a new issue for the possible change in behaviour when there are no indices or just open another pull request for that. If so, use which issue number for that? Just asking to get to know your process better.

@javanna
Copy link
Member Author

javanna commented Jan 8, 2015

Hi @cbuescher I would just open a new PR for that specific change, we don't necessarily need an issue for it (PR is the issue in that case).

cbuescher pushed a commit that referenced this issue Jan 9, 2015
The '_cat/segments' api was missing docs and a rest test which are added here.

Closes #5856
cbuescher pushed a commit that referenced this issue Feb 12, 2015
The '_cat/segments' api was missing docs and a rest test which are added here.

Closes #5856
cbuescher pushed a commit that referenced this issue Feb 12, 2015
The '_cat/segments' api was missing docs and a rest test which are added here.

Closes #5856
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
The '_cat/segments' api was missing docs and a rest test which are added here.

Closes elastic#5856
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
The '_cat/segments' api was missing docs and a rest test which are added here.

Closes elastic#5856
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes good first issue low hanging fruit help wanted adoptme v1.5.0 v2.0.0-beta1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants