-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing docs and tests for _cat/segments #5856
Comments
Hi, writing the Rest-Tests, I realized the _cat/segments command raises an "IndexMissingException" on an empty cluster where other commands like 'shards', 'aliases' etc... return silently. Want me to change that as well or test for the 404 error? |
Hey @cbuescher good point! I'd say keep it consistent with other cat apis, it makes sense not to return an exception if the cluster has no indices. Maybe send a separate PR for this change, so we can isolate it since we might need to mark it as breaking. |
Hi @javanna, do you think I should open a new issue for the possible change in behaviour when there are no indices or just open another pull request for that. If so, use which issue number for that? Just asking to get to know your process better. |
Hi @cbuescher I would just open a new PR for that specific change, we don't necessarily need an issue for it (PR is the issue in that case). |
The '_cat/segments' api was missing docs and a rest test which are added here. Closes #5856
The '_cat/segments' api was missing docs and a rest test which are added here. Closes #5856
The '_cat/segments' api was missing docs and a rest test which are added here. Closes #5856
The '_cat/segments' api was missing docs and a rest test which are added here. Closes elastic#5856
The '_cat/segments' api was missing docs and a rest test which are added here. Closes elastic#5856
We added
_cat/segments
api in #4711, but its docs are missing and we need to add some REST tests for it.The text was updated successfully, but these errors were encountered: