Use Lucene's defaults for CMS settings #5912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, I suggest pushing to master and 1.x branches |
|
Thanks, Shay, will do... Mike http://blog.mikemccandless.com On Tue, Apr 22, 2014 at 3:46 PM, Shay Banon notifications@github.comwrote:
|
| @@ -52,9 +53,8 @@ | |||
| public ConcurrentMergeSchedulerProvider(ShardId shardId, @IndexSettings Settings indexSettings, ThreadPool threadPool) { | |||
| super(shardId, indexSettings, threadPool); | |||
|
|
|||
| // TODO LUCENE MONITOR this will change in Lucene 4.0 | |||
| this.maxThreadCount = componentSettings.getAsInt("max_thread_count", Math.max(1, Math.min(3, Runtime.getRuntime().availableProcessors() / 2))); | |||
There was a problem hiding this comment.
wait - we don't allow to change it anymore? why don't we just pass the defaults to the componentSettings?
There was a problem hiding this comment.
argh, I left that comment, but seems to have been lost by github, yea, we need to keep those configurable
…ults to Lucene's
|
LGTM |
clintongormley
changed the title
clintongormley
added
>enhancement
:Core/Infra/Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5882
Lucene changed the settings a while back to be more conservative but ES has the old hardwired defaults.