Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snapshot/restore expand_wildcards option not consistent with other apis #6097

Closed
javanna opened this issue May 8, 2014 · 3 comments · Fixed by #9903
Closed

snapshot/restore expand_wildcards option not consistent with other apis #6097

javanna opened this issue May 8, 2014 · 3 comments · Fixed by #9903
Assignees
@imotov
Labels
>enhancement

Comments

@javanna
Copy link
Member

javanna commented May 8, 2014

With #4453 we introduced new indices options to be used across all apis that support multiple indices. Those options are listed here in our docs: http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/multi-index.html .

All apis support the expand_wildcards option that accepts open, closed or both as values, while create and restore snapshot apis accept expand_wildcards_open and expand_wildcards_closed as booleans instead. Looks like we should make them consistent with other apis.
@imotov imotov self-assigned this Dec 26, 2014
@javanna
Copy link
Member Author

javanna commented Feb 26, 2015

I think this got fixed right @imotov ? can we close?

@imotov
Copy link
Contributor

imotov commented Feb 26, 2015

@javanna no, it looks like it's still an issue https://github.com/elasticsearch/elasticsearch/blob/master/src/main/java/org/elasticsearch/action/admin/cluster/snapshots/create/CreateSnapshotRequest.java#L392

@javanna
Copy link
Member Author

javanna commented Feb 26, 2015

doh! I was almost sure we were using indices options there like in all other apis. thanks for checking.

imotov added a commit to imotov/elasticsearch that referenced this issue Feb 26, 2015
@imotov
Snapshot/Restore: make handling of expand_wildcards option consistent
f5d8ca8 
Closes elastic#6097
imotov added a commit to imotov/elasticsearch that referenced this issue Feb 26, 2015
@imotov
Snapshot/Restore: remove obsolete expand_wildcards_open and expand_wi…
7abe1ed 
…ldcards_close options

Related to elastic#6097
@imotov imotov mentioned this issue Feb 26, 2015
Merged
imotov added a commit to imotov/elasticsearch that referenced this issue Mar 31, 2015
@imotov
Snapshot/Restore: make handling of expand_wildcards option consistent
882c23a 
Closes elastic#6097
imotov added a commit to imotov/elasticsearch that referenced this issue Apr 23, 2015
@imotov
Snapshot/Restore: make handling of expand_wildcards option consistent
7bd4654 
Closes elastic#6097
imotov added a commit that referenced this issue Apr 23, 2015
@imotov
Snapshot/Restore: make handling of expand_wildcards option consistent
e8794e1 
Closes #6097
@imotov imotov mentioned this issue Apr 23, 2015
Closed
imotov added a commit to imotov/elasticsearch that referenced this issue Apr 23, 2015
@imotov
Snapshot/Restore: remove obsolete expand_wildcards_open and expand_wi…
0520211 
…ldcards_close options

In elastic#6097 we made snapshot/restore index option consistent with other API. Now we can remove old style options from master.

Closes elastic#10743
@imotov imotov mentioned this issue Apr 23, 2015
Merged
imotov added a commit to imotov/elasticsearch that referenced this issue Apr 23, 2015
@imotov
Snapshot/Restore: remove obsolete expand_wildcards_open and expand_wi…
60721b2 
…ldcards_close options

In elastic#6097 we made snapshot/restore index option consistent with other API. Now we can remove old style options from master.

Closes elastic#10743
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imotov imotov

Labels
>enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expand wildcards in snapshot imotov/elasticsearch
2 participants
@imotov @javanna