Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ignore_indices with ignore_unavailable, expand_wildcards and allow_no_indices #4453

Closed

Conversation

martijnvg
Copy link
Member

  • ignore_unavailable - Controls whether to ignore if any specified indices are unavailable, this includes indices
    that don't exist or closed indices. Either true or false can be specified.
  • allow_no_indices - Controls whether to fail if a wildcard indices expressions results into no concrete indices.
    Either true or false can be specified. For example if the wildcard expression foo* is specified and no indices
    are available that start with foo then depending on this setting the request will fail. This setting is also applicable
    when _all, * or no index has been specified.
  • expand_wildcards - Controls to what kind of concrete indices wildcard indices expression expand to. If open is
    specified then the wildcard expression if expanded to only open indices and if closed is specified then the wildcard expression if expanded only to closed indices. Also both values (open,closed) can be specified to expand to all indices.

There're a number of apis that support multiple indices, but didn't support the ignore_indices option. I haven't cut these apis over to the new indices options. I'll do that after this PR gets in. The following apis don't support for the new indices options yet: mlt, delete index, delete mapping, delete warmer, index exists, get indices settings, put index settings, put mappings and put warmer apis

Relates to #4436

…` and `allow_no_indices`.

* `ignore_unavailable` - Controls whether to ignore if any specified indices are unavailable, this includes indices
   that don't exist or closed indices. Either `true` or `false` can be specified.
* `allow_no_indices` - Controls whether to fail if a wildcard indices expressions results into no concrete indices.
   Either `true` or `false` can be specified. For example if the wildcard expression `foo*` is specified and no indices
   are available that start with `foo` then depending on this setting the request will fail. This setting is also applicable
   when `_all`, `*` or no index has been specified.
* `expand_wildcards` - Controls to what kind of concrete indices wildcard indices expression expand to. If `open` is
  specified then the wildcard expression if expanded to only open indices and if `closed` is specified then the wildcard
  expression if expanded only to closed indices. Also both values (`open,closed`) can be specified to expand to all indices.

Relates to elastic#4436
@ghost ghost assigned martijnvg Dec 16, 2013
@clintongormley
Copy link

Re allow_no_indices, I'd be tempted to leave that change out and only add it if somebody actually asks for it.

expand_wildcards and ignore_unavailable look fine to me

@martijnvg
Copy link
Member Author

pushed to master

@martijnvg martijnvg closed this Jan 2, 2014
karmi added a commit to elastic/elasticsearch-ruby that referenced this pull request Jan 12, 2014
…Index Settings" APIs

* prefix
* ignore_indices
* ignore_unavailable
* allow_no_indices
* expand_wildcards
* flat_settings

Related: elastic/elasticsearch#4436, elastic/elasticsearch#4453
karmi added a commit to elastic/elasticsearch-ruby that referenced this pull request Mar 13, 2014
@martijnvg martijnvg deleted the api-cleanup/indices_options branch May 18, 2015 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants