Allow to change concurrent merge scheduling setting dynamically #6098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to change the concurrent merge scheduler settings dynamically using the update settings API
|
The changes look fine, except we have no test coverage in Lucene verifying these live settings changes take effect / don't cause deadlock / whatnot. I know Rob is looking at randomizing this in the test infra, so we'll get some limited "first do no harm" coverage with that. |
|
I committed a test case to Lucene to confirm live changes to maxMergeCount take effect: http://svn.apache.org/r1593380 ... seems to be passing! Testing maxThreadCount is trickier ... |
kimchy
added a commit
that referenced
this pull request
May 12, 2014
Allow to change the concurrent merge scheduler settings dynamically using the update settings API closes #6098
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to change the concurrent merge scheduler settings dynamically using the update settings API