Allow 0 as a valid external version #6149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now all version types have officially required the version to be a positive long number. Despite of this has being documented, ES versions <=1.0 did not enforce it when using the `external` version type. As a result people have succesfully indexed documents with 0 as a version. In 1.1. we introduced validation checks on incoming version values and causing indexing request to fail if the version was set to 0. While this is strictly speaking OK, we effectively have a situation where data already indexed does not match the version invariant. To be lenient and adhere to spirit of our data backward compatibility policy, we have decided to allow 0 as a valid external version type. This is somewhat complicated as 0 is also the internal value of `MATCH_ANY`, which indicates requests should succeed regardles off the current doc version. To keep things simple, this commit changes the internal value of `MATCH_ANY` to `-3` for all version types. Since we're doing this in a minor release (and because versions are stored in the transaction log), the default `internal` version type still accepts 0 as a `MATCH_ANY` value. This is not a problem for other version types as `MATCH_ANY` doesn't make sense in that context. Closes elastic#5662
| } else { | ||
| out.writeVLong(version); | ||
| } | ||
| } |
There was a problem hiding this comment.
Should it use writeLong instead to be more future-proof (like UpdateRequest and IndexRequest do) eg. if we need a new special negative value?
There was a problem hiding this comment.
Yeah, I started the re-write with get requests which used vLong (which is correct here). You are right, in retrospect it's but to move to long... Will change.
|
I left a question about whether we should keep using VLong here but other than that this looks good to me. |
…change the new value of MATCH_ANY to old.
|
@jpountz I pushed an update. Your comment made me think some more about the writeLong version and it opened a can of worms... |
|
LGTM |
|
this goes also into master no? |
|
@s1monw yes. forgot a label. Adding. |
|
LGTM, but I think it might be cleaner to have another PR the will go only into master and will stop accepting |
bleskes
added a commit
that referenced
this pull request
May 18, 2014
These calls were introduced in pr #6149 as a backward compatibility layer for the previous value of `Versions.MATCH_ANY`. This is not needed as the translog never contains these values. On top of that, the calls are not effective as the stream the translog used is effectively not versioned (versioining is done on an item by item basis)
bleskes
added a commit
that referenced
this pull request
May 18, 2014
These calls were introduced in pr #6149 as a backward compatibility layer for the previous value of `Versions.MATCH_ANY`. This is not needed as the translog never contains these values. On top of that, the calls are not effective as the stream the translog used is effectively not versioned (versioining is done on an item by item basis)
bleskes
added a commit
to bleskes/elasticsearch
that referenced
this pull request
Mar 23, 2015
bleskes
added a commit
that referenced
this pull request
Mar 24, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now all version types have officially required the version to be a positive long number. Despite of this has being documented, ES versions <=1.0 did not enforce it when using the
externalversion type. As a result people have succesfully indexed documents with 0 as a version. In 1.1. we introduced validation checks on incoming version values and causing indexing request to fail if the version was set to 0. While this is strictly speaking OK, we effectively have a situation where data already indexed does not match the version invariant.To be lenient and adhere to spirit of our data backward compatibility policy, we have decided to allow 0 as a valid external version type. This is somewhat complicated as 0 is also the internal value of
MATCH_ANY, which indicates requests should succeed regardles off the current doc version. To keep things simple, this commit changes the internal value ofMATCH_ANYto-3for all version types.Since we're doing this in a minor release (and because versions are stored in the transaction log), the default
internalversion type still accepts 0 as aMATCH_ANYvalue. This is not a problem for other version types asMATCH_ANYdoesn't make sense in that context.Closes #5662