Remove backward compatibility layer introduced in #6149 #6229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do we still want to to use magic negative numbers for |
|
@spinscale we actually only need to worry about |
|
LGTM |
|
@bleskes needs merging, no? |
|
@bleskes still needs merging? |
clintongormley
added
the
:Distributed/CRUD
|
hey @bleskes this can be closed as we already removed all of the bw comp code from master right? |
bleskes
force-pushed
the
zero_external_version_remove_bw
branch
2 times, most recently
from
ed0ac86
to
caf0ccf
Compare
bleskes
force-pushed
the
zero_external_version_remove_bw
branch
from
caf0ccf
to
bdc10ec
Compare
|
@javanna not completely. Updated the PR to the latest master. Can you take a look? |
|
LGTM |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #6149 changed the
Versions.MATCH_ANYvalue from 0 to -3. This was done to allow 0 to be a valid external version. This commit removes the backward compatibility code from v2.0 and up.