Percolator: Fix assertion in percolation with nested docs #6263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assertion was triggered for percolating documents with nested object in mapping if the document did not actually contain a nested object. Instead, in this case we can just use the SingleDocumentPercolatorIndex.
|
LGTM |
|
Pushed to 1.2, 1.x and master. Should I also backport to 1.1 branch? |
brwe
added a commit
that referenced
this pull request
May 21, 2014
Assertion was triggered for percolating documents with nested object in mapping if the document did not actually contain a nested object. Reason: MultiDocumentPercolatorIndex checks if the number of documents is actualu >1. Instead we can just use the SingleDocumentPercolatorIndex in this case. closes #6263
brwe
added a commit
that referenced
this pull request
May 21, 2014
Assertion was triggered for percolating documents with nested object in mapping if the document did not actually contain a nested object. Reason: MultiDocumentPercolatorIndex checks if the number of documents is actualu >1. Instead we can just use the SingleDocumentPercolatorIndex in this case. closes #6263
brwe
added a commit
that referenced
this pull request
May 22, 2014
Assertion was triggered for percolating documents with nested object in mapping if the document did not actually contain a nested object. Reason: MultiDocumentPercolatorIndex checks if the number of documents is actualu >1. Instead we can just use the SingleDocumentPercolatorIndex in this case. closes #6263
brwe
changed the title
clintongormley
added
the
:Search/Percolator
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Assertion was triggered for percolating documents with nested object in mapping if the document did not actually contain a nested object. Reason: MultiDocumentPercolatorIndex checks if the number of documents is actualu >1. Instead we can just use the SingleDocumentPercolatorIndex in this case. closes elastic#6263
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Assertion was triggered for percolating documents with nested object in mapping if the document did not actually contain a nested object. Reason: MultiDocumentPercolatorIndex checks if the number of documents is actualu >1. Instead we can just use the SingleDocumentPercolatorIndex in this case. closes elastic#6263
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assertion was triggered for percolating documents with nested object
in mapping if the document did not actually contain a nested object.
Instead, in this case we can just use the SingleDocumentPercolatorIndex.