Bulk API: Fix return of wrong request type on failed updates

[tuxnco]

Opening an issue as suggested by @dadoonet after the following discussion on the mailing list: https://groups.google.com/forum/#!topic/elasticsearch/HAA4Y8Qziqg

When a bulk update action fails, an "index" entry can be returned in the response.

Example bulk commands list with an update command failing because the second date can't be parsed:

{ "index" : { "_index" : "test", "_type" : "type1", "_id" : "1" } } 
{ "title" : "Great Title of doc 1" } 
{ "index" : { "_index" : "test", "_type" : "type1", "_id" : "2" } } 
{ "title" : "Great Title of doc 2" } 
{ "update" : { "_index" : "test", "_type" : "type1", "_id" : "1" } } 
{ "doc" : { "date" : "2014-04-30T23:59:57" }} 
{ "update" : { "_index" : "test", "_type" : "type1", "_id" : "2" } } 
{ "doc" : { "date" : "2014-04-31T00:00:01" }} 
{ "delete" : { "_index" : "test", "_type" : "type1", "_id" : "1" } } 
{ "delete" : { "_index" : "test", "_type" : "type1", "_id" : "2" } }

Here is the actual response (elasticsearch v1.1):

{
  "took" : 4, 
  "errors" : true, 
  "items" : [ { 
    "index" : { 
      "_index" : "test", 
      "_type" : "type1", 
      "_id" : "1", 
      "_version" : 8, 
      "status" : 201 
    } 
  }, { 
    "index" : { 
      "_index" : "test", 
      "_type" : "type1", 
      "_id" : "2", 
      "_version" : 5, 
      "status" : 201 
    } 
  }, { 
    "update" : { 
      "_index" : "test", 
      "_type" : "type1", 
      "_id" : "1", 
      "_version" : 9, 
      "status" : 200 
    } 
  }, { 
    "index" : { 
      "_index" : "test", 
      "_type" : "type1", 
      "_id" : "2", 
      "status" : 400, 
      "error" : "MapperParsingException[failed to parse [date]]; nested: MapperParsingException[failed to parse date field [2014-04-31T00:00:01], tried both date format [dateOptionalTime], and timestamp number with locale []]; nested: IllegalFieldValueException[Cannot parse \"2014-04-31T00:00:01\": Value 31 for dayOfMonth must be in the range [1,30]]; " 
    } 
  }, { 
    "delete" : { 
      "_index" : "test", 
      "_type" : "type1", 
      "_id" : "1", 
      "_version" : 10, 
      "status" : 200, 
      "found" : true 
    } 
  }, { 
    "delete" : { 
      "_index" : "test", 
      "_type" : "type1", 
      "_id" : "2", 
      "_version" : 6, 
      "status" : 200, 
      "found" : true 
    } 
  } ] 
}

The problem here concerns the bulk update response for the forth item. It's key is index while it should be update, as in the following hand edited response:

{
  "took" : 4, 
  "errors" : true, 
  "items" : [ { 
    "index" : { 
      "_index" : "test", 
      "_type" : "type1", 
      "_id" : "1", 
      "_version" : 8, 
      "status" : 201 
    } 
  }, { 
    "index" : { 
      "_index" : "test", 
      "_type" : "type1", 
      "_id" : "2", 
      "_version" : 5, 
      "status" : 201 
    } 
  }, { 
    "update" : { 
      "_index" : "test", 
      "_type" : "type1", 
      "_id" : "1", 
      "_version" : 9, 
      "status" : 200 
    } 
  }, { 
    "update" : { 
      "_index" : "test", 
      "_type" : "type1", 
      "_id" : "2", 
      "status" : 400, 
      "error" : "MapperParsingException[failed to parse [date]]; nested: MapperParsingException[failed to parse date field [2014-04-31T00:00:01], tried both date format [dateOptionalTime], and timestamp number with locale []]; nested: IllegalFieldValueException[Cannot parse \"2014-04-31T00:00:01\": Value 31 for dayOfMonth must be in the range [1,30]]; " 
    } 
  }, { 
    "delete" : { 
      "_index" : "test", 
      "_type" : "type1", 
      "_id" : "1", 
      "_version" : 10, 
      "status" : 200, 
      "found" : true 
    } 
  }, { 
    "delete" : { 
      "_index" : "test", 
      "_type" : "type1", 
      "_id" : "2", 
      "_version" : 6, 
      "status" : 200, 
      "found" : true 
    } 
  } ] 
}

I didn't do a lot of code reading but a possible starting point for investigations is there: https://github.com/elasticsearch/elasticsearch/blob/1.1/src/main/java/org/elasticsearch/action/bulk/TransportShardBulkAction.java#L317