Removing plugin does not fail when plugin dir is read only #6735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you try to remove a plugin in read only dir, you get a successful result: ``` $ bin/plugin --remove marvel -> Removing marvel Removed marvel ``` But actually the plugin has not been removed. When installing, if fails properly: ``` $ bin/plugin -i elasticsearch/marvel/latest -> Installing elasticsearch/marvel/latest... Failed to install elasticsearch/marvel/latest, reason: plugin directory /usr/local/elasticsearch/plugins is read only ``` This change throw an exception when we don't succeed removing the plugin. Closes elastic#6546.
|
LGTM |
1 similar comment
|
LGTM |
clintongormley
added
>bug
v2.0.0-beta1
v1.3.0
:Core/Infra/Plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you try to remove a plugin in read only dir, you get a successful result:
But actually the plugin has not been removed.
When installing, if fails properly:
This change throw an exception when we don't succeed removing the plugin.
Closes #6546.