Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing plugin does not fail when plugin dir is read only #6735

Closed
wants to merge 1 commit into from

Commits on Jul 4, 2014

  1. Removing plugin does not fail when plugin dir is read only

    If you try to remove a plugin in read only dir, you get a successful result:
    
    ```
    $ bin/plugin --remove marvel
    -> Removing marvel
    Removed marvel
    ```
    
    But actually the plugin has not been removed.
    
    When installing, if fails properly:
    
    ```
    $ bin/plugin -i elasticsearch/marvel/latest
    -> Installing elasticsearch/marvel/latest...
    
    Failed to install elasticsearch/marvel/latest, reason: plugin directory /usr/local/elasticsearch/plugins is read only
    ```
    
    This change throw an exception when we don't succeed removing the plugin.
    
    Closes elastic#6546.
    dadoonet committed Jul 4, 2014
    Configuration menu
    Copy the full SHA
    2707ec4 View commit details
    Browse the repository at this point in the history