Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal: Remove unsafe unaligned memory access - illegal on SPARC #6962

Closed
jpountz opened this issue Jul 22, 2014 · 4 comments
Closed

Internal: Remove unsafe unaligned memory access - illegal on SPARC #6962

jpountz opened this issue Jul 22, 2014 · 4 comments
Labels
>bug v1.2.3 v1.3.0 v1.4.0.Beta1 v2.0.0-beta1

Comments

@jpountz
Copy link
Contributor

jpountz commented Jul 22, 2014

Unaligned memory access is illegal on several architectures (such as SPARC, see https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/elasticsearch/Nh-kXI5J6Ek/WXIZKhhGVHkJ for context).
@s1monw
Copy link
Contributor

s1monw commented Jul 22, 2014

oh boy

jpountz added a commit to jpountz/elasticsearch that referenced this issue Jul 22, 2014
@jpountz
Core: Drop UnsafeUtils.
858fbd7 
This class potentially does unaligned memory access and does not bring much
now that we switched to global ords for terms aggregations.

Close elastic#6962
@jpountz jpountz mentioned this issue Jul 22, 2014
Closed
@jpountz jpountz changed the title Remove unsafe unaligned memory access Core: Remove unsafe unaligned memory access Jul 23, 2014
jpountz added a commit that referenced this issue Jul 23, 2014
@jpountz
Core: Drop UnsafeUtils.
3c57800 
This class potentially does unaligned memory access and does not bring much
now that we switched to global ords for terms aggregations.

Close #6962
@s1monw
Copy link
Contributor

s1monw commented Jul 23, 2014

I added the labels for 1.3 and 1.2.3 this is basically making us not portable anymore and we should fix that! you should also remove the pom.xml entry that makes the unsafe utils and exception for forbidden APIs

@clintongormley clintongormley changed the title Core: Remove unsafe unaligned memory access Internal: Remove unsafe unaligned memory access - illegal on SPARC Jul 23, 2014
jpountz added a commit that referenced this issue Jul 23, 2014
@jpountz
Core: Drop UnsafeUtils.
a0f6bc7 
This class potentially does unaligned memory access and does not bring much
now that we switched to global ords for terms aggregations.

Close #6962
jpountz added a commit that referenced this issue Jul 23, 2014
@jpountz
Core: Drop UnsafeUtils.
2273a3a 
This class potentially does unaligned memory access and does not bring much
now that we switched to global ords for terms aggregations.

Close #6962
@jprante
Copy link
Contributor

jprante commented Oct 20, 2014

ES 1.3.4 still has issues, but this time in lzf compression codec. See file hs_err_pid26623.log at
https://gist.github.com/jprante/3c9ca8a85da13bd65226

@rjernst
Copy link
Member

rjernst commented Oct 20, 2014

@jprante The fix to remove unsafe usage in lzf compression was backported to 1.3.5 in #8078

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@jpountz
Core: Drop UnsafeUtils.
686cc63 
This class potentially does unaligned memory access and does not bring much
now that we switched to global ords for terms aggregations.

Close elastic#6962
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@jpountz
Core: Drop UnsafeUtils.
605dc32 
This class potentially does unaligned memory access and does not bring much
now that we switched to global ords for terms aggregations.

Close elastic#6962
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug v1.2.3 v1.3.0 v1.4.0.Beta1 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop UnsafeUtils jpountz/elasticsearch
4 participants
@rjernst @jpountz @jprante @s1monw