Default to all possible fields for items #7382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Items with no specified field now defaults to all the possible fields from the document source. Previously, we had required 'fields' to be specified either as a top level parameter or for each item. The default behavior is now similar to the MLT API.
|
What would happen eg. on a binary field or a geo shape? |
|
The field must be of type string so it will be skipped. |
|
This sounds good to me. Can you make it explicit in the documentation? |
alexksikes
force-pushed
the
feature/mlt-default-all-fields
branch
from
6ddfaa4
to
4e0eb0f
Compare
|
LGTM |
alexksikes
added a commit
that referenced
this pull request
Aug 22, 2014
Items with no specified field now defaults to all the possible fields from the document source. Previously, we had required 'fields' to be specified either as a top level parameter or for each item. The default behavior is now similar to the MLT API. Closes #7382
alexksikes
added a commit
that referenced
this pull request
Sep 8, 2014
Items with no specified field now defaults to all the possible fields from the document source. Previously, we had required 'fields' to be specified either as a top level parameter or for each item. The default behavior is now similar to the MLT API. Closes #7382
clintongormley
changed the title
clintongormley
changed the title
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Items with no specified field now defaults to all the possible fields from the
document source. Previously, we had required 'fields' to be specified either
as a top level parameter or for each item. The default behavior is now similar
to the MLT API.