The nested aggregator should iterate over the child doc ids in ascending order. #7514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
… ids in ascending order. The reverse_nested aggregator requires that the emitted doc ids are always in ascending order, which is already enforced on the scorer level, but this also needs to be enforced on the nested aggrgetor level otherwise incorrect counts are a result. Closes elastic#7505 Closes elastic#7514
martijnvg
force-pushed
the
bugs/reverse_nested_docid_order
branch
from
216cd60
to
2ba4e35
Compare
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
… ids in ascending order. The reverse_nested aggregator requires that the emitted doc ids are always in ascending order, which is already enforced on the scorer level, but this also needs to be enforced on the nested aggrgetor level otherwise incorrect counts are a result. Closes elastic#7505 Closes elastic#7514
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #7505