Remove unused search_query_hint parameter
#7691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will requests using search_query_hint now fail in the parser in 1.4? if so we should probably update the breaking changes doc |
I think the parameter would just get ignored through the REST layer, no failures. Java API users would have a compilation error. Anyways I think nobody ever used this parameter since it did nothing, I would prefer not to promote it as breaking change then, but more as a bugfix :) |
|
Since the option did nothing, I agree it should rather be a bugfix. LGTM. |
javanna
added a commit
that referenced
this pull request
Sep 11, 2014
clintongormley
added
v1.4.0.Beta
v1.4.0.Beta1
and removed
v1.4.0.Beta1
v1.4.0.Beta
labels
clintongormley
changed the title
search_query_hint parameter
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.