simple_query_string parser may fail with NumberFormatException while parsing flags

[imotov]

To reproduce:

curl -XDELETE 'http://localhost:9200/test/?pretty'

curl -XPUT 'http://localhost:9200/test/?pretty' -d '{
  "settings": {
    "index.number_of_shards": 1
  },
  "mappings": {
    "document": {
      "_routing" : {
        "required": true
      },
      "properties": {
        "title": {
          "type": "string"
    }
      }
    },
    "entity": {
      "_parent": {
        "type": "document"
      },
      "_routing" : {
        "required": true
      },
      "properties": {
        "body": {
          "type": "string"
        }
      }
    }
  }
}'


curl -XPOST 'http://localhost:9200/_bulk?pretty' --data-binary '
{"index": {"_index": "test", "_type": "document", "_id" : "1", "_routing": "1"}}
{"title": "New document"}
{"index": {"_index": "test", "_type": "entity", "_id" : "1", "_routing": "1", "_parent": "1"}}
{"body": "document body"}
'
curl -XPOST 'http://localhost:9200/test/_refresh?pretty'
curl -XGET 'http://localhost:9200/test/document/_search?pretty' -d '
{
  "query" : {
    "bool": {
      "minimum_should_match": 1,
      "disable_coord": true,
      "should": [
        {
          "simple_query_string": {
            "query": "old document",
            "default_operator": "and",
            "fields": ["title^10"],
            "flags": "NONE"
          }
        },
        {
          "has_child": {
            "query": {
              "bool": {
                "minimum_should_match": 1,
                "disable_coord": true,
                "should": [
                  {
                    "simple_query_string" : {
                      "query" : "\"document body\"~2",
                      "default_operator" : "and",
                      "flags": "PHRASE|SLOP",
                      "fields": ["body^5"]
                    }
                  },
                  {
                    "simple_query_string" : {
                      "query" : "document body",
                      "default_operator" : "and",
                      "fields": ["body"],
                      "flags": "NONE"
                    }
                  }
                ]
              }
            },
            "type": "entity",
            "score_mode": "sum"
          }
        }
      ]
    }
  }
}
'

The search fails with NumberFormatException[For input string: \"PHRASE|SLOP\"]; exception.

The problem occurs because simple_query_string parser is using XContentParser.hasTextCharacters() method to check for the presence of text in the token, while this method should be only used to detect internal presentation of the string.

The issue was originally reported on the mailing list https://groups.google.com/forum/#!topic/elasticsearch-ru/SeiifNQW-qo