Reduce memory usage in top children query #8165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kire321 Thanks for addressing this unnecessary usage of memory! The change looks good. Can you sign the CLA: http://www.elasticsearch.org/contributor-agreement/ ? Then this change can get merged in. |
|
I did sign the CLA... Do I need to associate the email I used to sign it with my github account? |
|
@kire321 As far as I know there is no need to for the email to be in sync with your GH account. |
|
@martijnvg Is there anything I need to do to help the CLA get through? |
|
@kire321 The CLA is fine, I'll pull your change in. |
martijnvg
changed the title
martijnvg
pushed a commit
that referenced
this pull request
Oct 20, 2014
martijnvg
pushed a commit
that referenced
this pull request
Oct 20, 2014
martijnvg
pushed a commit
that referenced
this pull request
Oct 20, 2014
|
@kire321 I pushed your change and thanks for brining this up. |
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8160