Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce memory usage in top children query #8165

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@kire321
Copy link
Contributor

kire321 commented Oct 20, 2014

Closes #8160

@martijnvg martijnvg self-assigned this Oct 20, 2014

@martijnvg

This comment has been minimized.

Copy link
Member

martijnvg commented Oct 20, 2014

@kire321 Thanks for addressing this unnecessary usage of memory! The change looks good. Can you sign the CLA: http://www.elasticsearch.org/contributor-agreement/ ? Then this change can get merged in.

@kire321

This comment has been minimized.

Copy link
Contributor Author

kire321 commented Oct 20, 2014

I did sign the CLA... Do I need to associate the email I used to sign it with my github account?

@martijnvg

This comment has been minimized.

Copy link
Member

martijnvg commented Oct 20, 2014

@kire321 As far as I know there is no need to for the email to be in sync with your GH account.

@kire321

This comment has been minimized.

Copy link
Contributor Author

kire321 commented Oct 20, 2014

@martijnvg Is there anything I need to do to help the CLA get through?

@martijnvg

This comment has been minimized.

Copy link
Member

martijnvg commented Oct 20, 2014

@kire321 The CLA is fine, I'll pull your change in.

@martijnvg martijnvg changed the title use less memory in top children query Parent/child: Reduce memory usage in top children query Oct 20, 2014

martijnvg added a commit that referenced this pull request Oct 20, 2014

martijnvg added a commit that referenced this pull request Oct 20, 2014

@martijnvg martijnvg closed this in 6dac6ec Oct 20, 2014

martijnvg added a commit that referenced this pull request Oct 20, 2014

@martijnvg

This comment has been minimized.

Copy link
Member

martijnvg commented Oct 20, 2014

@kire321 I pushed your change and thanks for brining this up.

@clintongormley clintongormley changed the title Parent/child: Reduce memory usage in top children query Reduce memory usage in top children query Jun 7, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.