native script custom explain feature removed in elasticsearch 1.4

[ursvasan]

I see that in issue #7245 , the interface ExplainableSearchScript and its use in ScriptScoreFunction is removed. I use that feature to customize (add all attributes in addition to query and parameters i use to compute the score in my script) the explain plan of my custom native script. It was fairly useful.

I am wondering why was it removed. Is there a different way to add my custom details to the explanation of script function ?

[brwe]

I was eager to remove code and apparently got a little overboard. I will make a pr shortly to add it again. I currently see now other way to add details from a search script to the explanation.

[ghiron]

@brwe : Could you add it back to v1.4 branch too please ?

[brwe]

@ghiron ok, pushed 5b031f6 to 1.4

[ghiron]

thank you @brwe !

[ursvasan]

thanks for adding it back @brwe. LGTM

[maxjakob]

Since ExplainableSearchScript.explain now takes a float it is not possible any more to print the full tree of explanations.
@brwe Is there a plan to revert #7245 completely?

[brwe]

@maxjakob there is now: #9826
Can you check if that is what you need?