Remove some more bwc code #8778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javanna
force-pushed
the
enhancement/remove_bwc_leftovers
branch
from
15ce6b6
to
12d9e8a
Compare
| @@ -449,39 +449,6 @@ public void testCommonTermsQueryStackedTokens() throws Exception { | |||
| } | |||
|
|
|||
| @Test | |||
| public void testOmitTermFreqsAndPositions() throws Exception { | |||
There was a problem hiding this comment.
why did you remove this? I think it's still valid?
There was a problem hiding this comment.
Right, I was not 100% sure either... will restore
|
left one comment other than that LGTM |
javanna
force-pushed
the
enhancement/remove_bwc_leftovers
branch
from
689c8f4
to
9ae893a
Compare
Some more code that was left for backwards compatibility can now be removed on master since 2.0 will require a full cluster restart. Closes elastic#8778
javanna
force-pushed
the
enhancement/remove_bwc_leftovers
branch
from
9ae893a
to
95c2d84
Compare
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more code that was left for backwards compatibility can now be removed on master since 2.0 will require a full cluster restart.