Remove status code from main action /
#8865
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wondering if it should be listed in breaking changes? |
| @@ -72,7 +72,6 @@ public void handleRequest(final RestRequest request, RestChannel channel, final | |||
| } | |||
|
|
|||
| builder.startObject(); | |||
| builder.field("status", status.getStatus()); | |||
There was a problem hiding this comment.
Is there a JAVA API equivalent to this? if so we should update that too so the two are consistent with each other?
There was a problem hiding this comment.
@colings86 I did not find any Java equivalent to GET /.
|
LGTM |
|
@clintongormley Do you think this should be listed as a breaking change? |
|
@dadoonet yes |
dadoonet
force-pushed
the
cleanup/remove-status-main-action
branch
from
683f161
to
c0c5c26
Compare
|
@colings86 @clintongormley I added a section in |
dadoonet
force-pushed
the
cleanup/remove-status-main-action
branch
from
c0c5c26
to
237ef3e
Compare
Today we give the HTTP status back within the HTTP response itself and within the JSON response as well:
```sh
curl localhost:9200/
```
```js
{
"status" : 200,
"name" : "Red Wolf",
"version" : {
"number" : "2.0.0",
"build_hash" : "6837a61d8a646a2ac7dc8da1ab3c4ab85d60882d",
"build_timestamp" : "2014-08-19T13:55:56Z",
"build_snapshot" : true,
"lucene_version" : "4.9"
},
"tagline" : "You Know, for Search"
}
```
dadoonet
force-pushed
the
cleanup/remove-status-main-action
branch
from
237ef3e
to
e2bcef7
Compare
|
Merged with 0526459 |
clintongormley
changed the title
status code from main action /
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we give the HTTP status back within the HTTP response itself and within the JSON response as well:
We can remove the
statusin elasticsearch 2.0.