Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the ability to delete mappings #8877

Closed
clintongormley opened this issue Dec 10, 2014 · 2 comments · Fixed by #10231
Closed

Remove the ability to delete mappings #8877

clintongormley opened this issue Dec 10, 2014 · 2 comments · Fixed by #10231
Assignees
@rjernst
Labels
>breaking :Search/Mapping Index mappings, including merging and defining field types v2.0.0-beta1

Comments

@clintongormley
Copy link

Currently, a user can delete a type entirely, which deletes the type, all documents of that type, and removes the associated fields. Unfortunately, if any documents of that type have already been indexed, then the fields are part of the index. Adding fields with the same name but a different data type will cause conflicts later on. (See #8530 (comment))

We should remove the ability to delete types/mappings.

Relates to #8870
@clintongormley clintongormley added :Search/Mapping Index mappings, including merging and defining field types >breaking v2.0.0-beta1 help wanted adoptme labels Dec 10, 2014
@clintongormley clintongormley mentioned this issue Dec 10, 2014
Closed
13 tasks
@clintongormley clintongormley mentioned this issue Dec 29, 2014
Closed
@clintongormley clintongormley mentioned this issue Jan 28, 2015
Closed
@mikemccand mikemccand mentioned this issue Mar 23, 2015
Closed
@rjernst rjernst removed the help wanted adoptme label Mar 24, 2015
@rjernst rjernst self-assigned this Mar 24, 2015
@rjernst rjernst mentioned this issue Mar 24, 2015
Merged
rjernst added a commit to rjernst/elasticsearch that referenced this issue Mar 24, 2015
@rjernst
Mappings: Remove delete mapping API
693d91e 
Deleting a type from an index is inherently dangerous because
the type can be recreated with new mappings which may conflict
with existing segments still using the old mappings. This
removes the ability to delete a type (similar to how deleting
fields within a type is not allowed, for the same reason).

closes elastic#8877
closes elastic#10231
rjernst added a commit to rjernst/elasticsearch that referenced this issue Mar 25, 2015
@rjernst
Rivers: Add back deletion river content on river removal.
de8160a 
In elastic#8877, the deletion of the type associated with a river was
removed. This change adds back the removal using a scan search
along with bulk delete requests.
@rjernst rjernst mentioned this issue Mar 25, 2015
Closed
@clintongormley clintongormley mentioned this issue Apr 5, 2015
Closed
rjernst added a commit to rjernst/elasticsearch that referenced this issue Apr 19, 2015
@rjernst
Mappings: Remove dead code after previous refactorings
554182e 
This is mostly removing code that handled deletion of types, which was
removed in elastic#8877.
@rjernst rjernst mentioned this issue Apr 19, 2015
Merged
rjernst added a commit to rjernst/elasticsearch that referenced this issue Apr 20, 2015
@rjernst
Mappings: Remove dead code after previous refactorings
89860df 
This is mostly removing code that handled deletion of types, which was
removed in elastic#8877.

closes elastic#10666
rjernst added a commit to rjernst/elasticsearch that referenced this issue Apr 20, 2015
@rjernst
Mappings: Remove dead code after previous refactorings
ba6a0c1 
This is mostly removing code that handled deletion of types, which was
removed in elastic#8877.

closes elastic#10666
rjernst added a commit to rjernst/elasticsearch that referenced this issue Apr 20, 2015
@rjernst
Mappings: Remove dead code after previous refactorings
3a04d3c 
This is mostly removing code that handled deletion of types, which was
removed in elastic#8877.

closes elastic#10666
@jasisz
Copy link

jasisz commented Aug 19, 2015

Just digged to that PR from the annoucment about removing delete by query and delete mapping in Elasticsearch 2.0. As far as I understand the problem is that the field name is stored directly in index and it is not possible to use it later with different type settings.

So how it will behave if in one index I have two types with mappings that have different types for the field named e.g. height in both? It would also give the same errors?

@clintongormley
Copy link
Author

@jasisz in 2.0 we explicitly forbid creating fields of the same name with conflicting mappings, for the same reason

@bharvidixit bharvidixit mentioned this issue Jan 25, 2016
Closed
@ezimuel ezimuel mentioned this issue Jul 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjernst rjernst

Labels
>breaking :Search/Mapping Index mappings, including merging and defining field types v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove delete mapping API rjernst/elasticsearch
3 participants
@clintongormley @rjernst @jasisz