ScriptService can deadlock entire nodes if script index is recovering #8901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
…ecovering we currently have operationThreaded set to false when indexing a script. This setting means that if we are executing the operation locally that we don't spawn a new thread for it althought incoming thread in this case is the network thread. Now sicne we are indexing here the engine is currently recovering which sometimes locks the engine for finalization blocks on a network call waiting for the recovery target to come back the internal lock in engine will never be released since we are waiting with our network thread for it to be released.
s1monw
force-pushed
the
fix_script_deadlock
branch
from
c1850bd
to
123fb2f
Compare
clintongormley
changed the title
clintongormley
changed the title
clintongormley
added
:Core/Infra/Scripting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we currently have operationThreaded set to false when indexing a script. This setting
means that if we are executing the operation locally that we don't spawn a new thread for
it although incoming thread in this case is the network thread. Now since we are indexing here
the engine is currently recovering which sometimes locks the engine for finalization blocks on
a network call waiting for the recovery target to come back the internal lock in engine will never be
released since we are waiting with our network thread for it to be released.
here is a smoking gun:
the interested reader follows the thread dump ;)