New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove jsonp support and associated tests #9242
Conversation
@clintongormley could you review please? |
Thanks for the PR @reuben-sutton - I've marked it for review. |
@reuben-sutton this PR looks pretty good to me, can you bring it up-to-date, I'd love to merge it! |
3d95eab
to
b9611d7
Compare
Hi @s1monw, rebased it now, sorry about the delay! |
LGTM @kimchy do you wanna take another look? |
@reuben-sutton could you do me a favor and add a line to |
LGTM |
b9611d7
to
85c221e
Compare
Added it @s1monw |
Remove jsonp support and associated tests, closes #9108
merged thanks!! |
Tests are all passing, obviously except the two jsonp related ones which I removed.
Closes #9108