Remove jsonp support and associated tests #9242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clintongormley could you review please? |
clintongormley
added
review
>breaking
v2.0.0-beta1
>enhancement
:Core/Infra/REST API
|
Thanks for the PR @reuben-sutton - I've marked it for review. |
|
@reuben-sutton this PR looks pretty good to me, can you bring it up-to-date, I'd love to merge it! |
reuben-sutton
force-pushed
the
remove_jsonp
branch
from
3d95eab
to
b9611d7
Compare
|
Hi @s1monw, rebased it now, sorry about the delay! |
|
LGTM @kimchy do you wanna take another look? |
|
@reuben-sutton could you do me a favor and add a line to |
|
LGTM |
reuben-sutton
force-pushed
the
remove_jsonp
branch
from
b9611d7
to
85c221e
Compare
|
Added it @s1monw |
s1monw
added a commit
that referenced
this pull request
Apr 1, 2015
Remove jsonp support and associated tests, closes #9108
|
merged thanks!! |
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are all passing, obviously except the two jsonp related ones which I removed.
Closes #9108