Fix shard state tranport action names #9440
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@s1monw says: "Oh boy!" :) |
|
LGTM On master, I think you would only have to fix the names? |
|
Yes in master it's easy, we don't care about bw compatibility aspects. The bw aspect in 1.x is tricky and not nice...but we have no other options than leave the wrong names around, which seems worse. |
When we renamed all of the transport actions in elastic#7105, shard started and failed were flipped around by mistake. This didn't cause any actual problem as the change was made in a backwards compatible manner. That said the action names ended up being wrong (just a naming problem, meaning that started == failed and failed ==started) and we have to fix it, still maintaining backwards compatibility.
javanna
force-pushed
the
fix/shard_state_action_names
branch
from
eb83019
to
2e86448
Compare
|
Agreed |
javanna
added a commit
that referenced
this pull request
Jan 27, 2015
When we renamed all of the transport actions in #7105, shard started and failed were flipped around by mistake. This didn't cause any actual problem as the change was made in a backwards compatible manner. That said the action names ended up being wrong (just a naming problem, meaning that started == failed and failed ==started) and we have to fix it, still maintaining backwards compatibility. Closes #9440
javanna
added a commit
that referenced
this pull request
Jan 28, 2015
In #9440 we restored the proper transport action names for shard started and shard failed events. ActionNamesTests needs to be adjusted according to that change.
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we renamed all of the transport actions in #7105, shard started and failed were flipped around by mistake.
This didn't cause any actual problem as the change was made in a backwards compatible manner. That said the action names ended up being wrong (just a naming problem, meaning that started == failed and failed ==started) and we have to fix it, still maintaining backwards compatibility.