Engine: close snapshots before recovery counter #9760
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we clean up after recoveries, we currently close the recovery counter first, followed up by the different snapshots. Since the recovery counter may issue a flush (introduced in elastic#9439) , the snapshot references prevent the flush from cleaning up the current translog file. This commit changes the order of the close command. Note: this is not a problem on master, as we moved the translog delete logic, making it kick in if needed when the ref counter goes to 0.
|
can we do next to the code the reason for the importance of close ordering? |
|
@kimchy comments added. |
| phase2Snapshot, phase3Snapshot); // hmm why can't we use try-with here? | ||
| // close the snapshots first to release the reference to the translog file, so a flush post recovery can delete it | ||
| Releasables.close(success, phase1Snapshot, phase2Snapshot, phase3Snapshot, | ||
| onGoingRecoveries, writeLock); // hmm why can't we use try-with here? |
There was a problem hiding this comment.
we can do try-with but we need to have 2 try blocks. since the write lock needs to be released last. but in a try / with blokc it's released before the finally block is executed
There was a problem hiding this comment.
it in-fact might make sense to have the write lock in an outer try catch to ensure it's released last?
There was a problem hiding this comment.
The problem with try with resources clause is that we release the phase1 and phase2 snapshots which are defined earlier in the scope. I can make the write lock use a try-with but this requires another catch to convert the exception the close method throws into a RecoveryEngineException. I'm not sure it's worth it.
|
left a minor comment |
|
@s1monw ping? |
|
ok fair enough LGTM then |
bleskes
added a commit
to bleskes/elasticsearch
that referenced
this pull request
Feb 27, 2015
When we clean up after recoveries, we currently close the recovery counter first, followed up by the different snapshots. Since the recovery counter may issue a flush (introduced in elastic#9439) , the snapshot references prevent the flush from cleaning up the current translog file. This commit changes the order of the close command. Note: this is not a problem on master, as we moved the translog delete logic, making it kick in if needed when the ref counter goes to 0. Closes elastic#9760
bleskes
added a commit
to bleskes/elasticsearch
that referenced
this pull request
Feb 27, 2015
When we clean up after recoveries, we currently close the recovery counter first, followed up by the different snapshots. Since the recovery counter may issue a flush (introduced in elastic#9439) , the snapshot references prevent the flush from cleaning up the current translog file. This commit changes the order of the close command. Note: this is not a problem on master, as we moved the translog delete logic, making it kick in if needed when the ref counter goes to 0. Closes elastic#9760
clintongormley
added
:Distributed/Recovery
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
When we clean up after recoveries, we currently close the recovery counter first, followed up by the different snapshots. Since the recovery counter may issue a flush (introduced in elastic#9439) , the snapshot references prevent the flush from cleaning up the current translog file. This commit changes the order of the close command. Note: this is not a problem on master, as we moved the translog delete logic, making it kick in if needed when the ref counter goes to 0. Closes elastic#9760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we clean up after recoveries, we currently close the recovery counter first, followed up by the different snapshots. Since the recovery counter may issue a flush (introduced in #9439) , the snapshot references prevent the flush from deleting the current translog file once it's no longer needed.
Note: this is not a problem on master, as we moved the translog delete logic, making it kick in if needed
when the ref counter goes to 0.
relates to #9226 (comment)