Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engine: close snapshots before recovery counter #9760

Closed
wants to merge 2 commits into from
Closed

Engine: close snapshots before recovery counter #9760

wants to merge 2 commits into from

Commits on Feb 19, 2015

  1. Engine: close snapshots before recovery counter 

    When we clean up after recoveries, we currently close the recovery counter first, followed up by the different snapshots. Since the recovery counter may issue a flush (introduced in elastic#9439) , the snapshot references prevent the flush from cleaning up the current translog file. This commit changes the order of the close command.

Note: this is not a problem on master, as we moved the translog delete logic, making it kick in if needed when the ref counter goes to 0.
    @bleskes
    bleskes committed Feb 19, 2015
    Configuration menu
    Copy the full SHA
    5311b56 View commit details
    Browse the repository at this point in the history

  2. add comments

    @bleskes
    bleskes committed Feb 19, 2015
    Configuration menu
    Copy the full SHA
    1bac4ea View commit details
    Browse the repository at this point in the history