Override jackson's TextBuffer to avoid NPE in SmileParser #10124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, there's an issue for this, #8629. |
|
I am kind of hesitating to do this. Not sure if it's worth adding a fork of this file or if we should just wait for a 2.6.0 release? @kimchy opinions? |
|
agreed its tricky, and I think this should be solved in Jackson and for now we can do #10333 |
|
Closing in favor of #10333. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you send a smile request with an empty value in the term query in ES 1.4.4, NPE may occur.
There is a bug in jackson FasterXML/jackson-core#182.
But they haven't released it yet.
That's why I proposed you to use a fixed version of this file until they release it.
Anyway you'd better know about this problem.