Fix #9469, fix #7408, fix #8041, fix #8285 #10178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Myll this looks pretty good in general, but can I ask you to split it up into 3 different pull requests? One for #9469, one for #8041, and one for #8285? That makes it easier to review and merge in. It looks like #7408 has been fixed already. Also, instead of commenting on the commit with "Fixes #nnnn", you can put it in the commit message and it will automatically be linked and the issue will be fixed when I merge it. |
|
Ok, will do. |
|
Closing this since @Myll will follow up with individual pull requests. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.