Tests: Add backward compatibility test for cluster state with blocks #10754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@javanna when you have time (no hurry), could you please have a look a this? Thanks :) |
| tc.addTransportAddress(n.getNode().address()); | ||
|
|
||
| ClusterStateResponse response = tc.admin().cluster().prepareState().setIndices("test-blocks") | ||
| .setBlocks(false).setNodes(false).execute().actionGet(); |
There was a problem hiding this comment.
why not ask for the blocks in the cluster state call?
There was a problem hiding this comment.
I feel stupid now, I'm not testing everything here... I updated the code.
|
left a small comment, looks good though, thanks a lot for taking care of this |
|
@javanna updated, let me know what you think. Thanks. |
|
LGTM |
tlrx
force-pushed
the
bwc-blocks-serialization
branch
from
90a755d
to
8b0674c
Compare
|
Thanks @javanna |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a bwc test when the cluster state has blocks. It refers to #9203 (comment).