Only check existence for absolute paths in env.resolveConfig()

[tlrx]

When resolving a path using env.resolveConfig(String), it first checks for the path existence in the current working directory. This can fails when the security manager is enabled and elasticsearch not started from the ES_HOME directory like with init.d/systemd scripts or also with ./path/to/elasticsearch/bin/elasticsearch: Files.exist() resolves against the working directory and fails with a SecurityException.

I'm not sure we always need to set "user.dir" so I add a check for absolute path. This couldn't hurt much since the following f1.toUri().toURL() expects an absolute path.

What do you think?

[tlrx]

More background: with ES installed with an RPM, creating a new index failed because the MapperService resolves env.resolveConfig("default-mapping.json") which calls Files.exists("default-mapping.json") and fails with a SecurityException.

[rjernst]

Why wouldn't we make the paths relative to ES_HOME if they are not absolute?

[tlrx]

When ES is installed with an RPM or Deb package, the configuration dir is not necessarily relative to ES_HOME, so we can't resolve path relative to ES_HOME.

[s1monw]

hmm I think this look good to me - this is actually more intuitive than what we did before? @rjernst

[rjernst]

Ok, I was confused about what we were resolving here, and after looking at the rest of the method I am now more confused. :)

I'm not sure this entire try/catch that is being modified should exist at all. It does not appear to be useful. What I see is the following logic:

1. Try to resolve the path on its own (only as an absolute path with your change)
2. Remove "/" from the beginning of path, making it relative (but this should no longer be possible with your change)
3. Take the path (which may have been absolute and made relative, at least on a nix system), and try to resolve it against the config dir.

It seems to me 2 is no longer valid (and was pretty bogus in the first place) and that 1 can actually be rolled into 3 because configFile.resolve(path) will just return path if it is absolute.

[tlrx]

Better fix has been merged in #10923, closing this one.