Add logging for failed TTL purges #11302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spinscale
added
>enhancement
:Core/Infra/Logging
|
@jaymode can you take a look? |
| if (response.isFailed()) failedItems++; | ||
| } | ||
| if (logger.isTraceEnabled()) { | ||
| logger.trace("Bulk deletion failures for [{}]/[{}] items, failure message: [{}]", failedItems, bulkResponse.getItems().length, bulkResponse.buildFailureMessage()); |
There was a problem hiding this comment.
can we s/Bulk/bulk here? I think we try to stay with lowercase in logs right?
|
LGTM. left a minor comment about capitialization. Thanks for taking care of this! |
spinscale
force-pushed
the
1505-issue-11019-log-ttl-deletion-failures
branch
from
c82e0a3
to
b22be7f
Compare
In order to get some information if the TTL purger thread could successfully delete all documents per bulk exection, this commit adds some logging. TRACE level logging will potentially contain a lot of information about all the bulk failures. Closes elastic#11019
spinscale
force-pushed
the
1505-issue-11019-log-ttl-deletion-failures
branch
from
b22be7f
to
85720d8
Compare
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to get some information if the TTL purger thread could
successfully delete all documents per bulk exection, this commit
adds some logging. TRACE level logging will potentially contain
a lot of information about all the bulk failures.
Closes #11019