Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fielddata_fields query string parameter was ignored. #11368

Closed
wants to merge 1 commit into from
Closed

fielddata_fields query string parameter was ignored. #11368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions rest-api-spec/test/search/10_source_filtering.yaml
View file
Open in desktop
Expand Up @@ -89,4 +89,10 @@
query: { match_all: {} }
- match: { hits.hits.0.fields: { include.field2 : [v2] }}
- is_true: hits.hits.0._source


- do:
search:
fielddata_fields: ["count"]
- match: { hits.hits.0.fields.count: [1] }

14 changes: 14 additions & 0 deletions src/main/java/org/elasticsearch/rest/action/search/RestSearchAction.java
View file
Open in desktop
Expand Up @@ -195,6 +195,20 @@ public static SearchSourceBuilder parseSearchSource(RestRequest request) {
}
}
}
String sFieldDataFields = request.param("fielddata_fields");
if (sFieldDataFields != null) {
if (searchSourceBuilder == null) {
searchSourceBuilder = new SearchSourceBuilder();
}
if (Strings.hasText(sFieldDataFields)) {
String[] sFields = Strings.splitStringByCommaToArray(sFieldDataFields);
if (sFields != null) {
for (String field : sFields) {
searchSourceBuilder.fieldDataField(field);
}
}
}
}
FetchSourceContext fetchSourceContext = FetchSourceContext.parseFromRestRequest(request);
if (fetchSourceContext != null) {
if (searchSourceBuilder == null) {
Expand Down