Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw exception if no elasticsearch.yml file is found #11592

Closed
wants to merge 4 commits into from
Closed

Throw exception if no elasticsearch.yml file is found #11592

wants to merge 4 commits into from

Conversation

saschamarkus
Copy link
Contributor

Log message to indicate that no elasticsearch.yml file was found

Added a warning despite other methods throw an exception to avoid breaking the former behaviour.
Closes #11510

@saschamarkus
Log message to indicate that no elasticsearch.yml file was found #1…
07711c9 
…1510

Added a warning fpr the log when a resource is not found.
Also added a test for this warning.
#11510
@saschamarkus
Revert "Log message to indicate that no elasticsearch.yml file was …
7eac193 
…found #11510"

This reverts commit 07711c9.
@saschamarkus
Log message to indicate that no elasticsearch.yml file was found #1…
9c70215 
…1510

Logging a warning if a file is not found.
Added a test for this log.
@clintongormley
Copy link

Hi @saschamarkus

Thanks for the PR. I think we should go for the exception instead of the warning. Anybody disagree?

@saschamarkus
Throws an exception when a resource is not found. Issue 11510
bf768f9 
Throws an exception when a resource is not found. Also added a test for
this warning.
#11510
@bookshelfdave
Copy link
Contributor

@saschamarkus would you mind rebasing against master to see if that helps with merge conflicts?

@clintongormley clintongormley changed the title Saschamarkus: Closes issue 11510 Throw exception if no elasticsearch.yml file is found Aug 5, 2015
@clintongormley
Copy link

Hi @saschamarkus

Just pinging in case you didn't see this before.

@saschamarkus
Copy link
Contributor Author

Hi,
Sorry for not answering to your messsage. I'll try to rebase this week.
Right now I've a bit busy but I think I'll manage it by the weekend.

Hi @saschamarkus https://github.com/saschamarkus

Just pinging in case you didn't see this before.

—
Reply to this email directly or view it on GitHub
#11592 (comment)
.

@saschamarkus saschamarkus deleted the saschamarkus_issue_11510 branch August 12, 2015 13:16
@saschamarkus
Copy link
Contributor Author

Hi,
I created another pull request with me changes on top of the current sources:
#12833

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
:Core/Infra/Settings Settings infrastructure and APIs >enhancement feedback_needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@saschamarkus @clintongormley @bookshelfdave