Query refactoring: SpanNearQueryBuilder and Parser #12156
Conversation
| public class SpanNearQueryBuilder extends AbstractQueryBuilder<SpanNearQueryBuilder> implements SpanQueryBuilder<SpanNearQueryBuilder> { | ||
|
|
||
| public static final String NAME = "span_near"; | ||
|
|
||
| private ArrayList<SpanQueryBuilder> clauses = new ArrayList<>(); | ||
| static boolean DEFAULT_IN_ORDER = true; | ||
| static boolean DEFAULT_COLLECT_PAYLOADS = true; |
There was a problem hiding this comment.
shouldnt these constant be public?
There was a problem hiding this comment.
Can do. btw. collectPayloads was lacking any documentation, also deep down in lucene land. Any idea where else to look, since when I make this public I'd like to have javadocs with it.
There was a problem hiding this comment.
you mean that our public getter for it has no javadocs either? :) you can have a look at NearSpansPayloadOrdered in lucene but you won't find much more javadocs, we can simply state that the flag controls whether we collect payloads or not :)
|
looks good left a few minor comments |
|
@javanna left a few comments regarding your questions. |
cbuescher
force-pushed
the
feature/query-refactoring-spannear
branch
from
7a19916
to
c9dbd7a
Compare
|
@javanna Added the comments and made default settings for flags public. |
| /** Default for flag controlling whether matches are required to be in-order */ | ||
| public static boolean DEFAULT_IN_ORDER = true; | ||
|
|
||
| /** Default for flag controlling whether payload is collected */ |
|
LGTM besides the minor comment I left |
cbuescher
force-pushed
the
feature/query-refactoring-spannear
branch
from
c9dbd7a
to
7efca09
Compare
Moving the query building functionality from the parser to the builders new toQuery() method analogous to other recent query refactorings. Relates to elastic#10217
cbuescher
force-pushed
the
feature/query-refactoring-spannear
branch
from
7efca09
to
c689e89
Compare
…annear Query refactoring: SpanNearQueryBuilder and Parser
…ring-spannear Query refactoring: SpanNearQueryBuilder and Parser
|
This change is breaking for the java api as it removes setter for mandatory slop parameter which needs to be set in the constructor instead. |
clintongormley
added
:Search/Search
Moving the query building functionality from the parser to the builders
new toQuery() method analogous to other recent query refactorings.
Relates to #10217
This PR is agains the query refactoring branch.