Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused methods hitsExecutionNeeded and hitsExecute from FetchSubPhase #12476

Closed
wants to merge 1 commit into from

Conversation

brwe
Copy link
Contributor

@brwe brwe commented Jul 27, 2015

The hits execution was never used by any sub fetch phase.

…ubPhase

The hits execution was never used by any sub fetch phase.
@brwe brwe added v2.0.0-beta1 review :Search/Search Search-related issues that do not fall into other categories labels Jul 27, 2015
@javanna
Copy link
Member

javanna commented Jul 27, 2015

Not sure, they might come handy when we want to address #11223 aka highlight all documents at once. On the other hand we can always restore them or add some similar mechanism when needed in the future. This was also exposed to plugins right? So who knows if any plugins is using this or not.

@brwe
Copy link
Contributor Author

brwe commented Jul 27, 2015

This was also exposed to plugins right? So who knows if any plugins is using this or not.

We could not plug in fetch phases in so far so I think that no plugin can use this.

Not sure, they might come handy when we want to address #11223 aka highlight all documents at once.

Indeed, it might help there. I also wonder if it might help for #12413 together with the pluggable fetch phases in #12400 . On the other hand I have the feeling that we though 'this might be handy' for four years now...

I am not passionate about it but since it is not a huge improvement and this might be handy at some point, I'll just leave all as is and close the pr again.

@brwe brwe closed this Jul 27, 2015
@clintongormley clintongormley changed the title remove unused methods hitsExecutionNeeded and hitsExecute from FetchS… Remove unused methods hitsExecutionNeeded and hitsExecute from FetchSubPhase Jul 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search/Search Search-related issues that do not fall into other categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants