PluginManager: Fix elastic.co download URLs, add snapshot ones #12641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spinscale
added
v2.0.0-beta1
:Core/Infra/Plugins
|
The change looks good to me. |
|
in case you are wondering, where the new URL scheme comes from, it was mentioned here #12270 |
|
Thanks @spinscale! I was wondering this when I started reviewing it! :) |
|
LGTM |
|
I like the snapshot support. LGTM FWIW |
The URL to download the main elasticsearch plugins did not match what the S3 wageon is supposed to write to. In addition this PR adds support for snapshots to access the snapshot S3 bucket, so we can possibly download snapshot versions of plugins. The format of the URLs stems from elastic#12270 Closes elastic#12632
spinscale
force-pushed
the
1507-plugin-manager-fix-path
branch
from
3933b03
to
88842f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL to download the main elasticsearch plugins did not match
what the S3 wagon is supposed to write to.
In addition this PR adds support for snapshots to access the
snapshot S3 bucket, so we can possibly download snapshot versions
of plugins.
Closes #12632