Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove environment from transport client #13383

Merged
merged 7 commits into from Sep 8, 2015
Merged

Remove environment from transport client #13383

merged 7 commits into from Sep 8, 2015

Commits on Sep 8, 2015

  1. Settings: Remove environment from transport client 

    Transport clients run embedded within external applications, so
elasticsearch should not be doing anything with the filesystem, as there
is not elasticsearch home.

This change makes a number of cleanups to the internal API for loading
settings and creating an environment. The loadFromConfig option was
removed, since it was always true except for tests. We now always
attempt to load settings from config a file when an environment is
created. The prepare methods were also simplified so there is now
prepareSettingsAndEnvironment which nodes use, and prepareSettings which
the transport client uses. I also attempted to improve the tests, but
there is a still a lot of follow up work to do there.

closes elastic#13155
    @rjernst
    rjernst committed Sep 8, 2015
    Copy the full SHA
    1ff49eb View commit details
    Browse the repository at this point in the history

  2. Change prepareSettingsAndEnvironment to prepareEnvironment

    @rjernst
    rjernst committed Sep 8, 2015
    Copy the full SHA
    d19e04f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into go_away_transport_paths

    @rjernst
    rjernst committed Sep 8, 2015
    Copy the full SHA
    92b62c0 View commit details
    Browse the repository at this point in the history

  4. Finish removing loadConfigSettings, and fix node startup to use correct 

    settings object
    @rjernst
    rjernst committed Sep 8, 2015
    Copy the full SHA
    2e63290 View commit details
    Browse the repository at this point in the history

  5. Add migration guide note about transport client changes to 

    settings/environment
    @rjernst
    rjernst committed Sep 8, 2015
    Copy the full SHA
    86ffa38 View commit details
    Browse the repository at this point in the history

  6. Address PR comments

    @rjernst
    rjernst committed Sep 8, 2015
    Copy the full SHA
    e218b31 View commit details
    Browse the repository at this point in the history

  7. Move logging specific settings setup to log configurator.

    @rjernst
    rjernst committed Sep 8, 2015
    Copy the full SHA
    f3fb702 View commit details
    Browse the repository at this point in the history