Expose all addresses that the transports are bound to #13586
Conversation
jaymode
added
review
:Distributed/Network
clintongormley
changed the title
| out.writeInt(boundAddresses.length); | ||
| for (TransportAddress address : boundAddresses) { | ||
| TransportAddressSerializers.addressToStream(out, address); | ||
| } | ||
| TransportAddressSerializers.addressToStream(out, publishAddress); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { |
There was a problem hiding this comment.
Is this the piece that gets logged at INFO level on startup? This would fix the confusing printout we do today.
So we may want to lower the per-address bind printout that we do at INFO level in Netty/HTTP, make it DEBUG or something, because we will be printing them all now at the end?
There was a problem hiding this comment.
Yeah this is what gets printed out. This is the current output:
[2015-09-21 13:42:27,541][INFO ][org.elasticsearch.http.netty] [Pyro] Bound http to address {127.0.0.1:9200}
[2015-09-21 13:42:27,542][INFO ][org.elasticsearch.http.netty] [Pyro] Bound http to address {[fe80::1]:9200}
[2015-09-21 13:42:27,543][INFO ][org.elasticsearch.http.netty] [Pyro] Bound http to address {[::1]:9200}
[2015-09-21 13:42:27,544][INFO ][org.elasticsearch.http ] [Pyro] publish_address {127.0.0.1:9200}, bound_addresses {127.0.0.1:9200}, {[fe80::1]:9200}, {[::1]:9200}
I'll make the INFO level per address messages DEBUG.
There was a problem hiding this comment.
Nice, much better. This removes a ton of confusion at startup, it just was not possible to easily fix without fixing this holder class the way you did.
|
this looks good to me. I added some minor suggestions. My only other wish, would be to add some heavy comments around the big conditionals with DEFAULT_PROFILE in the transport binding. Some of it is pre-existing conditions, but its hard to wrap your head around, and seeing the null checks etc is not intuitive towards figuring it out. I know i struggled with this part when first looking at this code, then figured it out for about 30 minutes (enough to make my changes) and promptly forgot it. |
|
Looks great, thanks for fixing this! |
jaymode
force-pushed
the
all_bound_addresses
branch
from
359cce8
to
78a9d61
Compare
In elastic#12942, the NettyTransport and NettyHttpServerTransport were updated to allow for binding to multiple addresses. However, the BoundTransportAddress holder only exposed the first address that the transport was bound to and this object is used to populate the values returned to the user via our APIs. This change exposes all of the bound addresses in the BoundTransportAddress holder, which allows for an accurate representation of all interfaces that elasticsearch is bound to and listening on.
jaymode
force-pushed
the
all_bound_addresses
branch
from
78a9d61
to
5b8b15e
Compare
In #12942, the NettyTransport and NettyHttpServerTransport were updated to allow for binding
to multiple addresses. However, the BoundTransportAddress holder only exposed the first address
that the transport was bound to and this object is used to populate the values returned to the user
via our APIs.
This change exposes all of the bound addresses in the BoundTransportAddress holder, which allows
for an accurate representation of all interfaces that elasticsearch is bound to and listening on.