Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate locale parameters in query_string and simple_query_string #13731

Closed
wants to merge 2 commits into from
Closed

Deprecate locale parameters in query_string and simple_query_string #13731

wants to merge 2 commits into from

Conversation

javanna
Copy link
Member

@javanna javanna commented Sep 23, 2015

The configured analysis chain should be used instead.

Relates to #13229

@clintongormley clintongormley changed the title Query DSL: deprecate locale parameters in query_string and simple_query_string Deprecate locale parameters in query_string and simple_query_string Sep 23, 2015
@javanna
Copy link
Member Author

javanna commented Sep 23, 2015

@rmuir can you have a look? if this looks good I will put up another PR to remove locale for 3.0.

@javanna
Query DSL: deprecate locale parameters in query_string and simple_que…
3d05327 
…ry_string

The configured analysis chain should be used instead.

Relates to elastic#13229
@javanna
docs
70803ed
@javanna
Copy link
Member Author

javanna commented Oct 5, 2015

I updated the PR to add some docs, which I had forgotten about in the first place. Reviews are welcome.

@javanna
Copy link
Member Author

javanna commented Oct 5, 2015

while looking into removing these as previously discussed, I bumped into org.apache.lucene.queryparser.classic.QueryParserBase#setLocale in lucene. I am then wondering why we shouldn't expose this setting if lucene allows to set it. Are we sure this is the best way forward? It is hard for me to tell. Will leave a comment also on the original issue.

@rmuir
Copy link
Contributor

rmuir commented Oct 5, 2015

I think the issue is that elasticsearch does not in fact use the configured analysis chain for wildcards, range queries, fuzzy queries, etc.

Lucene factories are annotated with the information needed to do this properly. I have explained the issue here: #9978

@javanna
Copy link
Member Author

javanna commented Oct 5, 2015

thanks for the explanation @rmuir that makes sense to me. I am closing this PR then, we can't move on till we have implemented what is described in #9978.

@javanna javanna closed this Oct 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@javanna @rmuir