Handle system policy correctly #14704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -253,7 +279,9 @@ static void addBindPermissions(Permissions policy, Settings settings) throws IOE | |||
| // a profile is only valid if its the default profile, or if it has an actual name and specifies a port | |||
| boolean valid = NettyTransport.DEFAULT_PROFILE.equals(name) || (Strings.hasLength(name) && profileSettings.get("port") != null); | |||
| if (valid) { | |||
| policy.add(new SocketPermission("localhost:" + transportRange, "listen,resolve")); | |||
| // listen is always called always called with 'localhost' but use wildcard to be sure, no name service is consulted. | |||
|
LGTM |
rmuir
added a commit
that referenced
this pull request
Nov 13, 2015
Just suck in the system policy, so its compatible with any version of java. It means it also respects configuration (e.g. for monitoring agents) Closes #14704
rmuir
added a commit
that referenced
this pull request
Nov 13, 2015
Just suck in the system policy, so its compatible with any version of java. It means it also respects configuration (e.g. for monitoring agents) Closes #14704
clintongormley
added
the
:Delivery/Packaging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have these lines:
But this is not really offically correct, and a problem going forwards, see https://bugs.openjdk.java.net/browse/JDK-8040059 and related issues (https://bugs.openjdk.java.net/secure/IssueNavigator.jspa?reset=true&jqlQuery=labels+%3D+deprivilege)
Current java 9 config is here: http://hg.openjdk.java.net/jdk9/jdk9/jdk/file/tip/src/java.base/share/conf/security/java.policy
So we must properly bring in the system policy, and just disable the bad defaults it has (with escape hatch in case there is some issue with that). This makes things better for users out of box.
It also makes us properly behaved, respecting user and system configuration. See https://docs.oracle.com/javase/8/docs/technotes/guides/security/PolicyFiles.html for more information.
Closes #14690