Introduce Local checkpoints #15390
Closed
Introduce Local checkpoints #15390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| /** | ||
| * an order list of bit arrays representing pending seq nos. The list is "anchored" in {@link #firstSeqNoInProcessSeqNo} |
There was a problem hiding this comment.
Typo: "an order list" -> "an ordered list"
| */ | ||
| final LinkedList<FixedBitSet> processedSeqNo; | ||
| final int bitArraysSize; | ||
| long firstSeqNoInProcessSeqNo = 0; |
There was a problem hiding this comment.
Nit: This name is a mouthful; can it just be firstSeqNoInProcess?
There was a problem hiding this comment.
yeah, it's an annoying name. Tweaked.
|
This is a much simpler implementation than the first. I've minor comments on LocalCheckpointService and the associated tests but otherwise LGTM. |
|
Thanks @jasontedor . I pushed another commit, addressing all your feedback |
| "index.translog.interval", | ||
| "index.translog.sync_interval", | ||
| "index.shard.inactive_time", | ||
| LocalCheckpointService.SETTINGS_BIT_ARRAYS_SIZE, |
There was a problem hiding this comment.
Nit: The indentation is off on this line.
|
I have one more small nit, but LGTM. |
|
pushed to |
64 tasks
clintongormley
added
:Engine
:Distributed/Engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the notion of a local checkpoint on the shard level. A local check point is defined as a the highest sequence number for which all previous operations (i.e. with a lower seq#) have been processed.
The current implementation is based on a fixed in memory bit array which is used in a round robin fashion. This introduces a limit to the spread between inflight indexing operation. We are still discussing options to work around this, but I think we should move forward toward a working system and optimize from there (and either remove this limitation or better understand it's implications).
relates to #10708
replaces #15111