Refactor UUID-generating methods out of Strings #17837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasontedor
added
>bug
review
:Core/Infra/Core
| // address will be set below | ||
| } | ||
|
|
||
| if (!isValidAddress(address)) { | ||
| logger.warn("Unable to get a valid mac address, will use a dummy address"); |
There was a problem hiding this comment.
Is it ok to have no feedback in this case? I guess given the initialization chain we had we weren't getting any anyway but maybe it'd be nice?
|
LGTM. Left a comment about not getting a log message we weren't getting anyway. It'd be nice if we knew if we were falling back to a bogus mac address, I guess, but maybe we can fix that problem in another PR outside of the "move stuff" PR. |
This commit refactors the UUID-generating methods out of Strings into their own class. The primary motive for this refactoring is to avoid a chain of class initializers from loading this class earlier than necessary. This was discovered when it was noticed that starting Elasticsearch without any active network interfaces leads to some logging statements being executed before logging had been initailized. Thus: - these UUID methods have no place being on Strings - removing them reduces spooky action-at-distance loading of this class - removed the troublesome, logging statements from MacAddressProvider, logging using statically-initialized instances of ESLogger are prone to this problem
|
Thanks @nik9000. I'm not heartbroken over the loss of the logging statement that was never there to begin with, especially since I do not immediately see a clean way to achieve logging there without using an offensive statically-initialized static logger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the UUID-generating methods out of
Stringsintotheir own class. The primary motive for this refactoring is to avoid a
chain of class initializers from loading this class earlier than
necessary. This was discovered when it was noticed that starting
Elasticsearch without any active network interfaces leads to some
logging statements being executed before logging had been
initailized. Thus:
StringsMacAddressProvider,logging using statically-initialized instances of
ESLoggerare proneto this problem
Closes #17819