Translog can delete valid .ckp file when views are closed after the translog #19035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ranslog There is simply a coding bug that only happens if translog views are closed after the translog itself is closed. this can happen for instance if we hit a disk full exception and try to repeatedly recover the translog. This will cause a translog-N.ckp file to be deleted since the wrong generation is used to generate the path to delete. This seems like a copy/past problem. This bug doesn't affect 5.0 Relates to elastic#16495
|
LGTM. good catch |
s1monw
added a commit
that referenced
this pull request
Jun 23, 2016
…ranslog (#19035) There is simply a coding bug that only happens if translog views are closed after the translog itself is closed. this can happen for instance if we hit a disk full exception and try to repeatedly recover the translog. This will cause a translog-N.ckp file to be deleted since the wrong generation is used to generate the path to delete. This seems like a copy/past problem. This bug doesn't affect 5.0 Relates to #16495
s1monw
added a commit
that referenced
this pull request
Jun 23, 2016
clintongormley
added
:Distributed/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is simply a coding bug that only happens if translog views are closed
after the translog itself is closed. this can happen for instance if we hit
a disk full exception and try to repeatedly recover the translog. This will
cause a translog-N.ckp file to be deleted since the wrong generation is used
to generate the path to delete. This seems like a copy/past problem.
This bug doesn't affect 5.0
Relates to #16495