Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove standardhtmlanalyzer #23705

Closed
wants to merge 1 commit into from

Conversation

Shepard1212
Copy link

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS that we support?
  • If you are submitting this code for a class then read our policy for that.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@Shepard1212 Shepard1212 changed the title Shepard1212 patch 1 remove standardhtmlanalyzer Mar 23, 2017
@Shepard1212 Shepard1212 force-pushed the Shepard1212-patch-1 branch 2 times, most recently from 9c3f39a to 6ebae8b Compare March 23, 2017 02:24
Since the StandardHtmlAnalyzer's functionality is easy to replicate using the HTMLStripCharFilter, so I remove this analyzer.
@cbuescher
Copy link
Member

@Shepard1212 sorry, this PR doesn't compile, also simply removing the constructors isn't enough here. As stated in #4704 we will need to support this for 6.0 and can only remove in 7.0

@cbuescher
Copy link
Member

I'm closing this for inactivity. @Shepard1212 if you're still interested in working on this please open an updated PR.

@cbuescher cbuescher closed this Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants