Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "routing" parameter to the terms lookup filter. This resolves issue 3233 #3234

Closed
wants to merge 2 commits into from

Conversation

daveey
Copy link

@daveey daveey commented Jun 25, 2013

#3233

This allows a custom routing parameter for the document lookup when using the "terms lookup" filter. Previously, only the document_id could be used.

@kimchy
Copy link
Member

kimchy commented Jun 25, 2013

agreed, we need to add it, there are a few things missing in the pull request, and the builder is not there. Also, teh handling if fieldMapper might be null was already fixed differently in the code.

I really want to push 0.90.2 quickly (possibly today), so I will work on the fix, apologies for not working with you properly on this one to get this in.

@daveey
Copy link
Author

daveey commented Jun 25, 2013

No problem! I am just excited for this to be fixed. <3

On Tue, Jun 25, 2013 at 2:45 AM, Shay Banon notifications@github.comwrote:

agreed, we need to add it, there are a few things missing in the pull
request, and the builder is not there. Also, teh handling if fieldMapper
might be null was already fixed differently in the code.

I really want to push 0.90.2 quickly (possibly today), so I will work on
the fix, apologies for not working with you properly on this one to get
this in.


Reply to this email directly or view it on GitHubhttps://github.com//pull/3234#issuecomment-19963714
.

@daveey daveey closed this Jun 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants